Skip to content

Commit

Permalink
Merge pull request #949 from wyardley/docs_maint_notice
Browse files Browse the repository at this point in the history
docs changes to reflect upcoming changes
  • Loading branch information
bastelfreak authored Oct 31, 2016
2 parents c4c7ab3 + 121493e commit 388310f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ Matthew Haughton <[email protected]> to Vox Pupuli.

## INSTALLING OR UPGRADING

**Please note**: This module is currently undergoing some structural
maintenance. Please take a look at [https://github.com/voxpupuli/puppet-nginx/blob/master/docs/hiera.md](https://github.com/voxpupuli/puppet-nginx/blob/master/docs/hiera.md)
before upgrading or installing Version 0.1.0 or greater.
**Please note**: This module is undergoing some structural maintenance.
You may experience breaking changes between minor versions.

This module manages NGINX configuration.

Expand Down
9 changes: 0 additions & 9 deletions docs/hiera.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Usage of Hiera

Passing through parameters from the main Class[nginx] and then having them chain down to Class[nginx::config] creates a ton of unnecessary spaghetti code that makes the module more complex to understand and difficult to extend.

Going forward, it is recommended to declare your changes in Hiera based on the system(s) role and location in your environment. In Puppet < 3.x, this is accomplished with Hiera bindings.

## Example Conversion
Expand All @@ -21,8 +19,6 @@ Moving this to hiera is simple. First, identify the appropriate hiera level to a
nginx::config::gzip: false
```
Magically, it's all done! Work through these until the deprecation notices go away.
## I (cannot/do not want to) use Hiera
Maybe for some reason, Hiera isn't being used in your organization. Or, you like to keep a certain amount of composibilty in you modules. Or, hidden option #3! Regardless, the recommended path is to instantiate your own copy of Class[nginx::config] and move on with life. Let's do another example.
Expand Down Expand Up @@ -54,8 +50,3 @@ class { 'nginx' :

The order in which this commands are parsed is important, since nginx looks for nginx::config via a defined(nginx::config) statement, which as of puppet 3.x is still parse-order dependent.

# Why again are you doing this?

Well, the fact of the matter, the old Package/Config/Service pattern has served us well, but times are a-changin. Many users are starting to manage their packages and service seperately outside of the traditional pattern (Docker, anyone?). This means that in order to stay true to the goals of Configuration Management, it is becoming necessary to make less assumptions about how an organizations graph is composed, and allow the end-user additional flexibility. This is requring a re-think about how to best consume this module.


0 comments on commit 388310f

Please sign in to comment.