Allow to specify package version and revision for ensure parameter

[dnsmichi]

First of all, thanks for starting your work on an official Puppet module. I've been previously using https://github.com/Nextdoor/puppet-kibana5 but am in progress migrating over here.

One thing I need to ensure is that the Kibana version is pinned. That version is used to determine the correct Elasticsearch API call for storing Kibana config, i.e. the default index (from filebeat, icingabeat, or anything else).

In order to achieve that, I'll also need to specify the exact package revision inside the version string on yum based systems.

Currently the regex checking for valid parameter values does not allow for that. I have modified and tested it working on CentOS7 by using a Vagrant box to install Elastic Stack using the official modules. Puppet version: 3.8.7

CLA is signed.

Pull request acceptance prerequisites:

• Signed the CLA (if not already signed)
• Rebased/up-to-date with base branch
• Updated CHANGELOG.md with patch notes (if necessary)
• Any relevant docs (README.markdown or inline documentation) updated (if necessary)
• Updated CONTRIBUTORS (if you would like attribution)
• Tests pass CI

[tylerjl]

Thanks for the contribution @dnsmichi, the change makes sense. It looks like your regex is too restrictive though, as the tests are failing because it's now requiring every package to have a package revision.

[tylerjl]

The extra *(-...) part of the regex probably should be optional? ?

[dnsmichi]

Ah, sorry. Shouldn't fiddle with regex on a Friday. Will push an update soon.

[dnsmichi]

So, various test cases evaluated over at https://regex101.com:

/^\d([.]\d+)*(-[\d\w]+)?$/

5.2.2
5.2.2-1
5.2.2-bpo1

Added the last one to tests too, adjust as needed please :)

[tylerjl]

Great work, thanks for the contribution @dnsmichi!