Bugfix java 17 support per atlassian upstream #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing check failing appears to be unrelated (init.pp hasn't been modified by this pr). |
|
@valentino-aguiar-gsa could you please rebase your branch? |
|
Hi, rebased. Didn't notice, thanks! |
|
Will adjust to only include the 1 commit shortly |
|
@valentino-aguiar-gsa can you please rebase against our master branch to get rid of the merge commit? |
See https://jira.atlassian.com/browse/JRASERVER-76224 for details on this. This snippet was taken directly from the setenv.sh script from JIRA 9.11.1.
valentino-aguiar-gsa
force-pushed
the
java17-jvmopens
branch
from
509e6fa to
0a4d22f
Compare
|
Sorry about that, all sorted. Note to self, dont use the 'sync' option in github web ui. |
h-haaks
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.atlassian.com/browse/JRASERVER-76224 for details on this. This snippet was taken directly from the setenv.sh script from JIRA 9.11.1.
Pull Request (PR) description
This PR updates setenv.sh with the fix from atlassian's upstream setenv.sh script. It simply checks if java 17 is in use, and if so, then it includes the JVM_OPENS parameters.
This Pull Request (PR) fixes the following issues
Fixes #412