-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicate scheme declaration when using proxy with SSL #396
Conversation
I think the actual fix for this to add a In fact, that was the case before the template was converted to epp and by accident Can you also rebase with master branch to fix conflicts and the failing specs? |
Makes sense! I'll rebase, update the PR, and see if I can author a spec for this condition. |
Updated the PR to use the I was able to write a spec context for specifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, please perform a rebase instead of a merge commit 😄
0f55205
to
ad17bfa
Compare
I rebased and removed the spacing and quotation change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits before we merged this 😄
And thanks for the contribution!
ca6ece5
to
a6df053
Compare
Pull Request (PR) description
scheme
key is present when iterating through the proxy hash.tomcat_native_ssl
without proxy settings.This Pull Request (PR) fixes the following issues
Fixes #395