Configure recommended JDBC connection-properties by default for PostgreSQL databases #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For PostgreSQL only. Also fixes voxpupuli#380
|
Installing the upgraded driver via the module would also be useful, but out of scope for this PR. |
|
For most installations not configuring the values does not matter, but JIRA will complain about it on upgrades so let's do it. |
bastelfreak
reviewed
May 18, 2021
bastelfreak
reviewed
May 18, 2021
bastelfreak
approved these changes
May 18, 2021
|
What's up with Ubuntu failing? I did nothing that would affect those tests... |
|
I'd like to merge this even though Ubuntu is failing. It seems there's just something in the |
oranenj
force-pushed
the
fix-connection-settings
branch
from
f05979e to
a08f33a
Compare
|
Bah, attempting to fix the tests just makes things worse. |
oranenj
force-pushed
the
fix-connection-settings
branch
from
ca16ebf to
1fe14a4
Compare
|
Since the only changes after approval were to make the MySQL tests run properly, I'll just merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PostgreSQL only. Also fixes #380
Pull Request (PR) description
This Pull Request (PR) fixes the following issues