Refactor most configuration to use EPP templates #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not public API
oranenj
force-pushed
the
template-cleanup
branch
from
ab4c865 to
7349e02
Compare
ekohl
approved these changes
Apr 15, 2021
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
oranenj
changed the title
oranenj
changed the title
bastelfreak
approved these changes
Apr 15, 2021
cegeka-jenkins
pushed a commit
to cegeka/puppet-jira
that referenced
this pull request
Oct 13, 2021
Refactor most configuration to use EPP templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves most configuration-related stuff from init.pp to config.pp, cleans up its dependencies and then converts most templates from ERB to EPP.
There are no API changes and I'm pretty sure the EPP templates result in identical output (at least they all stay the same on my Jira instance)