Merge pull request #343 from kenyon/fix-fact-script-mode

facts.pp: use less restrictive mode for the external fact script
voxpupuli · Feb 14, 2021 · dc8adc1 · dc8adc1
2 parents 540c609 + 935864c
commit dc8adc1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/manifests/facts.pp b/manifests/facts.pp
@@ -57,6 +57,6 @@
   file { "/etc/${dir}facter/facts.d/jira_facts.rb":
     ensure  => $ensure,
     content => template('jira/facts.rb.erb'),
-    mode    => '0500',
+    mode    => '0755',
   }
 }
diff --git a/spec/classes/jira_facts_spec.rb b/spec/classes/jira_facts_spec.rb
@@ -14,7 +14,7 @@
         pe_external_fact_file = '/etc/puppetlabs/facter/facts.d/jira_facts.rb'
         external_fact_file = '/etc/puppetlabs/facter/facts.d/jira_facts.rb'
 
-        it { is_expected.to contain_file(external_fact_file) }
+        it { is_expected.to contain_file(external_fact_file).with_mode('0755') }
         it { is_expected.to compile.with_all_deps }
 
         # Test puppet enterprise shebang generated correctly