Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins not pinned and updated when using jenkins class #380

Closed
omar952 opened this issue Sep 28, 2015 · 1 comment · Fixed by #389
Closed

Plugins not pinned and updated when using jenkins class #380

omar952 opened this issue Sep 28, 2015 · 1 comment · Fixed by #389
Labels
bug Something isn't working

Comments

@omar952
Copy link

omar952 commented Sep 28, 2015

I have hieradata containing plugin names and versions which I pass to jenkins::plugin type in the same class as I call the jenkins class to install a version of Jenkins. However, I have to run the script twice, as the second run is needed to pin plugins from the bundled version of jenkins and to install the ones I have specified in my hieradata.

Perhaps I am not using the module as intended? Please advise
@jhoblitt jhoblitt added the bug Something isn't working label Oct 8, 2015
@jhoblitt
Copy link
Member

jhoblitt commented Oct 8, 2015

This is a resource ordering problem. exec["create-pinnedfile-${name}"] should come after the plugin is downloaded.

rtyler pushed a commit to rtyler/puppet-jenkins that referenced this issue Oct 9, 2015
Correct the relationship when managing the pinned file for a plugin
0dc8e62 
The reason this wasn't working before was largely due to the `onlyif` statement
in the exec resource, wihch ends up requiring puppet to run twice to get the
pinned file to work properly

Fixes voxpupuli#380
rtyler pushed a commit to rtyler/puppet-jenkins that referenced this issue Oct 9, 2015
Correct the relationship when managing the pinned file for a plugin
78e83d1 
The reason this wasn't working before was largely due to the `onlyif` statement
in the exec resource, wihch ends up requiring puppet to run twice to get the
pinned file to work properly

Fixes voxpupuli#380
jhoblitt added a commit to jhoblitt/puppet-jenkins that referenced this issue Oct 10, 2015
@jhoblitt
remove seperate resources for handling plugin extension
32c015e 
There were two orthogonal resource chains for handling plugins with with
the .hpi & .jpi extension.  This commit unifies the two code paths.  It
should fix the resource ordering problem that causes it to take two runs
to install a plugin and pin it.

resolves voxpupuli#380
@jhoblitt jhoblitt mentioned this issue Oct 10, 2015
Merged
@sfhardman sfhardman mentioned this issue Jan 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove seperate resources for handling plugin extension jhoblitt/puppet-jenkins
2 participants
@jhoblitt @omar952