Ensure stable key order when processing hashes

[luitzifa]

We encountered a problem with changing config files because the data was dynamically generated.

Even though it might just be possible to create a stable insertion order in other places, this should really not be necessary. We want to generate stable icinga config files without having to jump though any extra hoops.

[SimonHoenscheid]

The tests should work before we merge this. The change itself looks good and makes sense

[lbetz]

First, please let us known what puppet version and which version of ruby you're using? The behavior you describe sounds like ruby 1.8.7.

[luitzifa]

I'm using

# puppetserver ruby --version
jruby 9.3.14.0 (2.6.8) 2024-02-20 0db23ddd14 OpenJDK 64-Bit Server VM 17.0.14+7-Debian-1deb12u1 on 17.0.14+7-Debian-1deb12u1 +jit [x86_64-linux]
# puppetserver --version
puppetserver version: 7.17.3

on Debian Bookworm provided by puppetlabs.

The problem arises if the order of the keys in the hash is not stable. This affects us because the hashes originate from puppetdb queries.

[lbetz]

What kind of queries? By the module itself?

[lbetz]

The order is not so easy to change, there are users for whom this is important.

[luitzifa]

The order is not so easy to change, there are users for whom this is important.

I didn't thought about that.

The puppetdb queries are made by our code. It is certainly possible to determine the order on our site in advance.

[lbetz]

"The puppetdb queries are made by our code. It is certainly possible to determine the order on our site in advance."
Would be the easier and shorter way if it's possible, I think.

[luitzifa]

We'll do that. It's fine by me, if you reject this PR.