Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune icinga::icinga2_attributes function call #704

Closed
lbetz opened this issue Jun 27, 2022 · 1 comment
Closed

Tune icinga::icinga2_attributes function call #704

lbetz opened this issue Jun 27, 2022 · 1 comment
Labels
enhancement
Milestone
v3.4.0

Comments

@lbetz
Copy link
Contributor

lbetz commented Jun 27, 2022

closure_scope wasted time:

https://github.com/Icinga/puppet-icinga2/blob/88e057065790b9b7621f48d0d902b628b00f580d/lib/puppet/functions/icinga2/icinga2_attributes.rb#L30-L40

Because function api 4.x has its own scope, move merge and cancat to a puppet code based function.
@lbetz
Copy link
Contributor Author

lbetz commented Jun 27, 2022

refs #702

lbetz added a commit that referenced this issue Jun 27, 2022
@lbetz
fix #704 Tune icinga::icinga2_attributes function call
f0d3536
@lbetz lbetz added this to the v3.4.0 milestone Jun 27, 2022
lbetz added a commit that referenced this issue Jun 27, 2022
@lbetz
fix #704 Tune icinga::icinga2_attributes function call
b5530d7
lbetz added a commit that referenced this issue Jun 27, 2022
@lbetz
fix #704 Tune icinga::icinga2_attributes function call
48bde42
@lbetz lbetz closed this as completed Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v3.4.0
Development

No branches or pull requests
1 participant
@lbetz