Fix performance of grafana_user
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
force-pushed
the
user_performance
branch
2 times, most recently
from
ad8a9a7 to
b009abf
Compare
alexjfisher
changed the title
grafana_user
Previously, the number of API calls to look up the details of a single user was equal to `1 + the number of existing users`. This made managing multiple users exponentially slow. The way the types in this module are written, (with the Grafana API user credentials being parameters of each resource), we can't implement `prefetch` to fetch all users just once; but we can change the implementation to directly lookup the user we're trying to manage. This is _much_ faster!
alexjfisher
force-pushed
the
user_performance
branch
from
b009abf to
5a98be7
Compare
bastelfreak
approved these changes
May 27, 2022
|
For reference, using the following puppet code and puppet apply to talk to a remote grafana server (in the same datacenter, but not as quick as localhost with no ssl!). grafana_user { range("testuser00","testuser99"):
ensure => present,
grafana_url => 'https://remotegrafana.example.com',
grafana_user => 'admin',
grafana_password => 'admin', }Before change... Creating 100 users Running Puppet again (ensuring those 100 users are still present) Second run is slower as the average number of grafana users is > 100 for the entire duration, and not ~ 50. After change... ie 100 times faster for this use case of just 100 users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the number of API calls to look up the details of a single user was equal to
1 + the number of existing users.This made managing multiple users exponentially slow.
The way the types in this module are written, (with the Grafana API user credentials being parameters of each resource), we can't implement
prefetchto fetch all users just once; but we can change the implementation to directly lookup the user we're trying to manage.This is much faster!