Fix rubocop after disabling BooleanSymbol cop #271
Conversation
There was a problem hiding this comment.
This doesn't revert the changes that were made to the types/providers.
Suggest doing a revert of 70c2adc and then rerunning the original autocorrect rake task.
|
Makes sense, Thanks! |
Sorry, just realised you might not have had the full context, and only come across the issue because of the now failing build. |
This reverts commit 70c2adc.
root-expert
force-pushed
the
fix-rubocop
branch
from
d7f3058 to
6c4df65
Compare
root-expert
force-pushed
the
fix-rubocop
branch
from
6c4df65 to
771a032
Compare
| @@ -147,7 +147,7 @@ def password=(value) | |||
| save_datasource | |||
| end | |||
|
|
|||
| # rubocop:disable Naming/PredicateName | |||
| # rubocop:disable Style/PredicateName | |||
There was a problem hiding this comment.
For these rubocop complains although autofix changed them?
There was a problem hiding this comment.
what did it complain about? In an older rubocop version it was in the Naming namespace and the cop got moved to Style (or the other way around).
There was a problem hiding this comment.
https://github.com/voxpupuli/puppet-grafana/runs/4368546552?check_suite_focus=true
It's not erroring though
| @@ -218,7 +218,7 @@ def existing_permissions | |||
| end | |||
| end | |||
|
|
|||
| def permission_data(destroy = false) # rubocop:disable Style/OptionalBooleanParameter | |||
| def permission_data(destroy = false) | |||
There was a problem hiding this comment.
Thoughts for this one?
I added # rubocop:disable Style/OptionalBooleanParameter
| @@ -182,7 +182,7 @@ def permission=(value) | |||
| def new_permission | |||
| key = resource[:user] ? :userId : :teamId | |||
| subject_id = resource[:user] ? user[:id] : team[:id] | |||
| permission = case resource[:permission] # rubocop:disable Style/HashLikeCase | |||
| permission = case resource[:permission] | |||
| @@ -183,7 +183,7 @@ | |||
| describe 'create data_dir' do | |||
| it { is_expected.to contain_file('/var/lib/grafana').with_ensure('directory') } | |||
| end | |||
| when 'FreBSD' | |||
| when 'FreeBSD' | |||
Pull Request (PR) description
This Pull Request (PR) fixes the following issues