Implement plugin versions

lib/puppet/provider/grafana_dashboard_permission/grafana.rb

@@ -218,7 +218,7 @@ def existing_permissions
     end
   end
 
-  def permission_data(destroy = false) # rubocop:disable Style/OptionalBooleanParameter
+  def permission_data(destroy = false)
     raise format('Unknown dashboard: %s', resource[:dashboard]) unless dashboard
 
     endpoint = format('%s/dashboards/id/%s/permissions', grafana_api_path, dashboard[:id])

lib/puppet/provider/grafana_datasource/grafana.rb

@@ -147,7 +147,7 @@ def password=(value)
     save_datasource
   end
 
-  # rubocop:disable Style/PredicateName
+  # rubocop:disable Naming/PredicateName
   def is_default
     datasource[:is_default]
   end
@@ -156,7 +156,7 @@ def is_default=(value)
     resource[:is_default] = value
     save_datasource
   end
-  # rubocop:enable Style/PredicateName
+  # rubocop:enable Naming/PredicateName
 
   def basic_auth
     datasource[:basic_auth]

lib/puppet/provider/package/grafana.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+require 'puppet/provider/package'
+
+Puppet::Type.type(:package).provide :grafana, parent: Puppet::Provider::Package do
+  desc 'This provider only handles grafana plugins.'
+
+  has_feature :installable, :install_options, :uninstallable, :upgradeable, :versionable
+
+  has_command(:grafana_cli, 'grafana-cli') do
+    is_optional
+  end
+
+  def self.pluginslist
+    plugins = {}
+
+    grafana_cli('plugins', 'ls').split(%r{\n}).each do |line|
+      next unless line =~ %r{^(\S+)\s+@\s+((?:\d\.).+)\s*$}
+
+      name = Regexp.last_match(1)
+      version = Regexp.last_match(2)
+      plugins[name] = version
+    end
+
+    plugins
+  end
+
+  def self.instances
+    pluginslist.map do |k, v|
+      new(name: k, ensure: v, provider: 'grafana')
+    end
+  end
+
+  def query
+    plugins = self.class.pluginslist
+
+    if plugins.key?(resource[:name])
+      { ensure: plugins[resource[:name]], name: resource[:name] }
+    else
+      { ensure: :absent, name: resource[:name] }
+    end
+  end
+
+  def latest
+    grafana_cli('plugins', 'list-versions', resource[:name]).lines.first.strip
+  end
+
+  def update
+    cmd = %w[plugins update]
+    cmd << install_options if resource[:install_options]
+    cmd << resource[:name]
+
+    grafana_cli(*cmd)
+  end
+
+  def install
+    cmd = %w[plugins install]
+    cmd << install_options if resource[:install_options]
+    cmd << resource[:name]
+    cmd << resource[:ensure] unless resource[:ensure].is_a? Symbol
+
+    grafana_cli(*cmd)
+  end
+
+  def install_options
+    join_options(resource[:install_options])
+  end
+
+  def uninstall
+    grafana_cli('plugins', 'uninstall', resource[:name])
+  end
+end

lib/puppet/type/grafana_user.rb

@@ -41,7 +41,7 @@
 
   newproperty(:password) do
     desc 'The password for the user'
-    def insync?(_is) # rubocop:disable Naming/MethodParameterName
+    def insync?(_is)
       provider.check_password
     end
   end
@@ -60,7 +60,7 @@ def insync?(_is) # rubocop:disable Naming/MethodParameterName
     defaultto :false
   end
 
-  def set_sensitive_parameters(sensitive_parameters) # rubocop:disable Style/AccessorMethodName
+  def set_sensitive_parameters(sensitive_parameters) # rubocop:disable Naming/AccessorMethodName
     parameter(:password).sensitive = true if parameter(:password)
     super(sensitive_parameters)
   end

spec/acceptance/grafana_plugin_spec.rb

@@ -95,5 +95,31 @@ class { 'grafana':
         end
       end
     end
+
+    context 'grafana plugins' do
+      it 'installs' do
+        pp = <<-EOS
+        class { 'grafana':
+          version => 'latest',
+        }
+
+        package { 'grafana-image-renderer':
+          provider => 'grafana',
+        }
+        EOS
+        # Run it twice and test for idempotency
+        apply_manifest(pp, catch_failures: true)
+        apply_manifest(pp, catch_changes: true)
+      end
+
+      describe package('grafana-image-renderer') do
+        it { is_expected.to be_installed }
+      end
+
+      describe service('grafana-server') do
+        it { is_expected.to be_enabled }
+        it { is_expected.to be_running }
+      end
+    end
   end
 end

spec/classes/grafana_spec.rb

@@ -17,7 +17,6 @@
         it { is_expected.to contain_class('grafana::service') }
       end
 
-      # rubocop:disable RSpec/EmptyExampleGroup
       context 'with parameter install_method is set to package' do
         let(:params) do
           {
@@ -461,7 +460,6 @@
           end
         end
       end
-      # rubocop:enable RSpec/EmptyExampleGroup
     end
   end
 end