Mask/redact password and secure_json_data in grafana_datasource; require at least puppet 6.1.0 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… passwords aren't leaked
nmaludy
force-pushed
the
bugfix/secure-json-data
branch
from
fcf18bd to
5515a3a
Compare
|
this looks good to me, but I'm far away from being an expert for sensitive type. I'm referring to @alexjfisher here. |
|
Dear @nmaludy, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
alexjfisher
requested changes
Oct 8, 2020
|
I guess a puppet 6 requirement is fine now since Puppet 5 is EoL? @nmaludy can you rebase please? |
|
@bastelfreak rebase complete! |
|
can you take a look the linter complains and raise the required puppet version in metadata.json to 6.1.0 ? |
bastelfreak
changed the title
bastelfreak
approved these changes
Jan 4, 2021
bastelfreak
added
backwards-incompatible
and removed
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when configuring a datasource with a password, the
grafana_datasourceresource would leak on the CLI and in the puppet report:Notice: /Stage[main]/Profile::Grafana/Grafana_datasource[postgres]/secure_json_data: secure_json_data changed to { 'password' => 'mysweetpassword1' } (corrective)Now with this fix, the
passwordorsecure_json_datafield changes emit the following diff:There were also several linting / whitespace issues caught by CI, i've fixed these in the PR.