Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SLES support #220

Merged
merged 1 commit into from
Aug 22, 2020
Merged

add SLES support #220

merged 1 commit into from
Aug 22, 2020

Conversation

tuxmea
Copy link
Member

@tuxmea tuxmea commented Aug 20, 2020

Pull Request (PR) description

Add SLES support to get installed via package

This Pull Request (PR) fixes the following issues

n/a

@tuxmea tuxmea requested a review from dhoppe August 20, 2020 11:21
@dhoppe dhoppe added enhancement New feature or request tests-fail labels Aug 20, 2020
@tuxmea tuxmea force-pushed the sles_support branch 2 times, most recently from 1215205 to 463f0e1 Compare August 20, 2020 11:58
@tuxmea tuxmea closed this Aug 20, 2020
@tuxmea
Copy link
Member Author

tuxmea commented Aug 20, 2020

trigger ci

@tuxmea tuxmea reopened this Aug 20, 2020
@tuxmea
Copy link
Member Author

tuxmea commented Aug 20, 2020

The only failure I see is the lint check:

$ bundle exec rake $CHECK

manifests/init.pp:170:manifest_whitespace_opening_brace_after:ERROR:there should be a single space or single newline after an opening brace
manifests/validator.pp:12:manifest_whitespace_opening_brace_after:ERROR:there should be a single space or single newline after an opening brace

Both errors looks like false positives to me.

@tuxmea tuxmea closed this Aug 20, 2020
@tuxmea
Copy link
Member Author

tuxmea commented Aug 20, 2020

trigger build

@tuxmea tuxmea reopened this Aug 20, 2020
@tuxmea tuxmea removed the tests-fail label Aug 21, 2020
@tuxmea
Copy link
Member Author

tuxmea commented Aug 21, 2020

All tests pass now. @dhoppe can you please review?

bastelfreak
bastelfreak reviewed Aug 21, 2020
View reviewed changes
metadata.json Outdated Show resolved Hide resolved
@alexjfisher alexjfisher merged commit f8402a7 into voxpupuli:master Aug 22, 2020
@tuxmea tuxmea deleted the sles_support branch August 22, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@dhoppe dhoppe dhoppe approved these changes

@alexjfisher alexjfisher alexjfisher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuxmea @alexjfisher @bastelfreak @dhoppe