Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exists logic for plugin provider #920

Merged
merged 4 commits into from
Feb 14, 2018

Conversation

tylerjl
Copy link
Contributor

@tylerjl tylerjl commented Feb 13, 2018

Pull request acceptance prerequisites:

  • Signed the CLA (if not already signed)
  • Rebased/up-to-date with base branch
  • Tests pass
  • Updated CHANGELOG.md with patch notes (if necessary)
  • Updated CONTRIBUTORS (if attribution is requested)

As part of an upstream change to support sub-plugins, unexpected files (such as .name) in plugin directories will now cause unexpected behavior, including the inability of Elasticsearch to start up correctly. Historically this module has used a helper file called .name in the root of plugin directories to track the name/version in order to determine when plugins should be updated/installed, so this change updates the provider to use a more friendly method of consuming plugin metadata by leveraging the pre-existing Java properties file.

While the change modifies how the plugin provider works pretty drastically, the tests still work as expected and it should handle the edge cases that I can think of. At the very least, it's a much more tenable solution than dropping arbitrary .name metadata files to try and track plugin state.

@tylerjl tylerjl added this to the Next Release milestone Feb 14, 2018
@tylerjl tylerjl merged commit 0b830bb into voxpupuli:master Feb 14, 2018
@tylerjl tylerjl deleted the plugin-provider-refactor-exists branch February 14, 2018 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant