Refactor exists
logic for plugin provider
#920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request acceptance prerequisites:
As part of an upstream change to support sub-plugins, unexpected files (such as
.name
) in plugin directories will now cause unexpected behavior, including the inability of Elasticsearch to start up correctly. Historically this module has used a helper file called.name
in the root of plugin directories to track the name/version in order to determine when plugins should be updated/installed, so this change updates the provider to use a more friendly method of consuming plugin metadata by leveraging the pre-existing Java properties file.While the change modifies how the plugin provider works pretty drastically, the tests still work as expected and it should handle the edge cases that I can think of. At the very least, it's a much more tenable solution than dropping arbitrary
.name
metadata files to try and track plugin state.