-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to use Hiera 5 #1158
Conversation
cbea974
to
0b0cf87
Compare
83287a1
to
0a68fb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Have you used some tool to rewrite the yaml files? I think that the explicit ~
in better than emptiness, and some quoting was changed, but I can live with this. I started to work on a tool that focus on sorting YAML files but keep comments and values the way they are written, maybe you used something i am looking for?
The "Tool" I used is "25 Lines of plain Ruby": read in the YAML, sort the Keys with the Exception of
Too bad, the Comments have to get migrated manually. |
@cocker-cc just released yaml-sort if you want to give it a try 😜 |
This looks very well implemented. Is there a Place to discuss it? |
@cocker-cc I opened issues on the project page ;-) |
0a68fb4
to
296acf6
Compare
- oracle-7-x64 | ||
- ubuntu-server-1404-x64 | ||
- ubuntu-server-1604-x64 | ||
- amazonlinux-1-x64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite sure this file isn't used anymore and can be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, But this is not Subject, of this PR.
elasticsearch::api_basic_auth_username: ~ | ||
elasticsearch::api_ca_file: ~ | ||
elasticsearch::api_ca_path: ~ | ||
elasticsearch::api_basic_auth_password: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if something is undef, it doesn't need to be added to hiera at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if something is undef, it doesn't need to be added to hiera at all
Not without adding = undef,
to the Class-Parameter.
Anyhow. This is not Subject, of this PR.
296acf6
to
f2fd005
Compare
- migrate Fixtures-Hiera to Hiera 5 - sort YAML-Files alphabetically
f2fd005
to
eaf6f74
Compare
Pull Request (PR) description
This Pull Request (PR) fixes the following issues