Gemfile: Pin to Puppet ~> 7.24 #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step to deprecate puppet 6. We raise the default puppet version in the Gemfile in our modules. also we limit it to 7.x so we don't pull in puppet 8 by accident. And we pin to 7.24 or newer to prevent issues with ruby-concurrent.
smortex
approved these changes
Apr 27, 2023
|
I'm not sure yet. We saw breaking CI pipelines because we had |
ekohl
reviewed
Apr 27, 2023
| @@ -13,7 +13,7 @@ | |||
| Jenkinsfile: | |||
| delete: true | |||
| Gemfile: | |||
| puppet_version: '>= 6.0' | |||
| puppet_version: '~> 7.24' | |||
There was a problem hiding this comment.
Previously it also allowed Puppet 8, now it no longer does. Is this intended?
There was a problem hiding this comment.
indeed. we allowed puppet 8 and that break our CI. To prevent that in the future it makes sense to limit to a single version. and the gemfile has an environment variable to overwrite it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to deprecate puppet 6. We raise the default puppet version in the Gemfile in our modules. also we limit it to 7.x so we don't pull in puppet 8 by accident. And we pin to 7.24 or newer to prevent issues with ruby-concurrent.