Set add_mocked_facts #693
Merged
Set add_mocked_facts #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question is: should this be on by default? |
Just hit this woking with a module that want to use the postgresql module that wants to use the |
|
I just went through theforeman/foreman-installer-modulesync#148 (or really, PRs are still open) where I did the same thing. I completely forgot I already submitted this PR. I'll rebase it tomorrow. And I'm sure @evgeni will appreciate this, or laugh at me. |
This uses the new add_mocked_facts from voxpupuli-test, which is currently only a PR.
|
Rebased to resolve conflicts. When we merge this and modulesync we should go over the modules to purge any |
bastelfreak
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new add_mocked_facts from voxpupuli-test, which is currently only a PR. That's why this is a draft.