puppet6 is released, use it with acceptance tests #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we instead add another travis slot for this? @dhollinger recommended this. We could test on puppet6 + puppet6-nightlies to catch issues early. |
Dan33l
force-pushed
the
puppet6-without-nightly
branch
from
c804dbd to
3241f9d
Compare
|
Yes i agree. I probably misunderstood a resource limit about CI slots. |
|
IMHO the nightly testing could be good if we have cron runs of modules but AFAIK we don't do so now. That'd mean we have to get a PR in and just get lucky to see something break. |
|
@ekohl I would like to have that, but who has time for that to configure it :(. I think nevertheless we should test the nightlies and afterwards try to enable the crons in travis |
Dan33l
force-pushed
the
puppet6-without-nightly
branch
2 times, most recently
from
516db70 to
bbe4479
Compare
Dan33l
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now puppet6 is realsed it is better to not use nightly as default.