Fix beaker dependencies #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
approved these changes
Aug 10, 2018
This was tested in voxpupuli/puppet-zabbix@8cb583e
bastelfreak
force-pushed
the
beakerfuckup
branch
from
5da0905 to
31ce16a
Compare
bastelfreak
force-pushed
the
beakerfuckup
branch
from
31ce16a to
b18ef84
Compare
ekohl
reviewed
Aug 13, 2018
| @@ -19,6 +19,6 @@ group :development do | |||
| gem 'travis-lint' | |||
| end | |||
|
|
|||
| gem 'modulesync' | |||
| gem 'modulesync', git: 'https://github.com/voxpupuli/modulesync.git' | |||
There was a problem hiding this comment.
Why do we need modulesync from git? Do we need a specific patch? I'd prefer to work to get a release out if needed.
There was a problem hiding this comment.
the code to open up PRs is still unreleased. Yes, a new release is the preferred solution
There was a problem hiding this comment.
In general I try to add a comment why something like this is needed, ideally with a git commit sha / github commit link. Otherwise you forget it and in a year you forgot why it was changed and nobody dares to change it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.