restructure content fetching from github #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnelson0
reviewed
Apr 28, 2018
bin/get_all_the_diffs
Outdated
| begin | ||
| response = open("https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.sync.yml") | ||
| rescue OpenURI::HTTPError | ||
| puts "something is fucked up with #{repo} and https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.sync.yml" |
There was a problem hiding this comment.
We should remove vulgarity from error messages. Some may appreciate it but it’s not fully inclusive.
bin/get_all_the_diffs
Outdated
| response = open("https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.sync.yml") | ||
| rescue OpenURI::HTTPError | ||
| puts "something is fucked up with #{repo} and https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.sync.yml" | ||
| modules_that_have_missing_secrets << repo |
There was a problem hiding this comment.
Is there a plan for this variable? I want to say it should be named more accurately (missing_sync?) but I don’t see it used anywhere at all.
bin/get_all_the_diffs
Outdated
| puts "We need to add Puppets version_requirement to: #{modules_without_puppet_version_range.join(', ')}" if modules_without_puppet_version_range.count > 0 | ||
| puts "We need to adjust the list of operatingsystemrelease for Debian to #{DEBIAN_SUPPORT_RANGE} on: #{supports_wrong_debian_version.join(', ')}" | ||
| puts "We need to adjust the list of operatingsystemrelease for Ubuntu to #{UBUNTU_SUPPORT_RANGE} on: #{supports_wrong_ubuntu_version.join(', ')}" | ||
| puts "We need to adjust the list of operatingsystemrelease for CentOS to #{CENTOS_SUPPORT_RANGE} on: #{supports_wrong_centos_version.join(', ')}" |
There was a problem hiding this comment.
Should these have if guards as well?
bin/get_all_the_diffs
Outdated
| begin | ||
| response = open("https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.msync.yml") | ||
| rescue OpenURI::HTTPError | ||
| puts "something is fucked up with #{repo} and https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.msync.yml" | ||
| puts "something is fucked up with #{repo} and https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.msync.yml" if DEBUG |
There was a problem hiding this comment.
Can we remove the vulgarity here, please? It’s going to be funny to some and off putting to others.
bin/get_all_the_diffs
Outdated
| begin | ||
| response = open("https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.msync.yml") | ||
| rescue OpenURI::HTTPError | ||
| puts "something is fucked up with #{repo} and https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.msync.yml" | ||
| puts "something is fucked up with #{repo} and https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.msync.yml" if DEBUG | ||
| modules_that_were_added_but_never_synced << repo |
bin/get_all_the_diffs
Outdated
| response = open("https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.sync.yml") | ||
| rescue OpenURI::HTTPError | ||
| puts "something is fucked up with #{repo} and https://raw.githubusercontent.com/voxpupuli/#{repo}/master/.sync.yml" if DEBUG | ||
| modules_that_have_missing_secrets << repo |
|
@bastelfreak what about the operating system release sections, will they spit out junk if there’s no issues? |
|
@rnelson0 I fixed that |
rnelson0
approved these changes
May 21, 2018
|
It looks like you're done but still has WIP in the title, let me know if you're good to go or if I should revoke my review. |
bastelfreak
changed the title
|
nope, all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.