Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask tty's in docker acceptance nodesets #324

Merged
merged 1 commit into from
Mar 10, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 9, 2017

Since beaker containers are privileged these tty's can interfere with
the system tty's. This can be an unpleasant surprise for those running
on Linux.

Since beaker containers are privileged these tty's can interfere with
the system tty's. This can be an unpleasant surprise for those running
on Linux.
@bastelfreak
Copy link
Member

Is the tty required if we want to debug the container and enter it after a puppet run?

@ekohl
Copy link
Member Author

ekohl commented Mar 9, 2017

I'm not sure if docker attach actually uses a tty (I'd guess a pts), but /sbin/init is non-interactive anyway. Beaker uses SSH server to connect I used that instead. A small script (that assumes you have one running container):

#!/bin/sh
container=$(docker ps --quiet)
ip=$(docker inspect $container | jq '.[0]["NetworkSettings"]["IPAddress"]' -r)
ssh -o UserKnownHostsFile=/dev/null root@$ip

The password is root.

@bastelfreak
Copy link
Member

Ah correct, we've got ssh. Should we document the ssh script somewhere in the README.md or in the CONTRIBUTING.md we place in each repository?

@bastelfreak bastelfreak merged commit e492c75 into voxpupuli:master Mar 10, 2017
@bastelfreak
Copy link
Member

@ekohl could you please add the script later to one of the readmes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants