Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15 Changed the link to the code of conduct for pupet #28

Merged
merged 1 commit into from
Oct 19, 2015
Merged

#15 Changed the link to the code of conduct for pupet #28

merged 1 commit into from
Oct 19, 2015

Conversation

blacktoko
Copy link
Contributor

Fixes #15 Linked to the specific code of conduct from the puppet-community repo. Adapted from http://contributor-covenant.org/version/1/2/0/

Linked to the specific code of conduct from the puppet-community repo. Adapted from http://contributor-covenant.org/version/1/2/0/
@ffrank
Copy link
Contributor

ffrank commented Oct 19, 2015

Neat, thanks!

Could you amend your commit and have the message start with (#15), then push -f to your branch again? This aids book-keeping wrt. the github issues.

@blacktoko blacktoko changed the title Changed the link to the code of conduct for pupet #15 Changed the link to the code of conduct for pupet Oct 19, 2015
@blacktoko
Copy link
Contributor Author

Should i recommit the change with the new message in a new pull request? (sorry if this is a obviouse question but this is the first time i am doing this).

@igalic
Copy link
Contributor

igalic commented Oct 19, 2015

@blacktoko no need to create a new pull request.
after changing the commit message with git commit --ammend, just run git push --force, as @ffrank suggests!


seeing as this is your first pull-request, and you may not be familiar with github's flow, i think we can just merge it as-is…

igalic added a commit that referenced this pull request Oct 19, 2015
#15 Changed the link to the code of conduct for pupet
@igalic igalic merged commit dffe180 into voxpupuli:master Oct 19, 2015
@blacktoko
Copy link
Contributor Author

Thanks for your help and the link about the flow! I will study it :-)

@blacktoko blacktoko deleted the patch-1 branch October 19, 2015 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants