Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppet 4.x-only modules and Gemfile #102

Closed
reidmv opened this issue Mar 21, 2016 · 1 comment
Closed

Puppet 4.x-only modules and Gemfile #102

reidmv opened this issue Mar 21, 2016 · 1 comment

Comments

@reidmv
Copy link
Member

reidmv commented Mar 21, 2016

Currently the Gemfile template will include the Puppet 3.x gem. There does not appear to be a way to parameterize what version of the Puppet gem is included on a per-module basis. This causes problems when trying to integrate a Puppet 4.x-only module into modulesync. See https://github.com/voxpupuli/puppet-dotnet/pull/9/files#r53225512.

Is this a problem? If so, how should it be resolved?
@reidmv reidmv mentioned this issue Mar 21, 2016
Closed
@igalic
Copy link
Contributor

igalic commented Mar 24, 2016

I definitely think it's a problem that should be solved
similarly, we have lots of modules that don't do any acceptance tests, but sync Gems and spec/acceptance for them.

I don't know how to solve it yet, though.
maybe a global option in .sync.yml?

reidmv added a commit to reidmv/modulesync_config that referenced this issue Mar 24, 2016
@reidmv
Add "puppet_version" global .sync.yml config opt
9b515e8 
There should be a way for a module to specify what version of Puppet to
require in the Gemfile. This commit adds a .sync.yml top-level variable
that can be used to set this. It expects a version specifier in the same
format a Gemfile would, e.g. "~> 4.0".

Fixes voxpupuli#102
@reidmv reidmv mentioned this issue Mar 24, 2016
Merged
reidmv added a commit to reidmv/modulesync_config that referenced this issue Mar 24, 2016
@reidmv
Add "puppet_version" global .sync.yml config opt
f3c283e 
There should be a way for a module to specify what version of Puppet to
require in the Gemfile. This commit adds a .sync.yml variable that can
be used to set this. It expects a version specifier in the same format a
Gemfile would, e.g. "~> 4.0".

Fixes voxpupuli#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reidmv @igalic