-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allPropertiesRequired
and noAdditionalProperties
options
#494
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 89.98% 90.00% +0.02%
==========================================
Files 76 76
Lines 1577 1581 +4
==========================================
+ Hits 1419 1423 +4
Misses 158 158
☔ View full report in Codecov by Sentry. |
Rubocop is complaining that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually don't really care about the RuboCop Metrics, especially when it comes to tests.
Adds the
allPropertiesRequired
andnoAdditionalProperties
options. Each of these options include a subset of the functionality thatstrict
provides.Here is how the three options interact, as a truth table:
strict
allPropertiesRequired
noAdditionalProperties
These changes are not breaking -
strict
behaves the same way that it did previously.