Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix fragment when used with extended schema #434

Closed
wants to merge 2 commits into from

Conversation

zdennis
Copy link
Contributor

@zdennis zdennis commented Apr 15, 2019

What this PR does

This PR fork resolves an issue with extended schema validation.

From the original author of the patch (circa 2016):

fix fragment when used with extended schema

This refactors some of Validator to fix an issue with validating a fragment of an extended schema against a json object. The problem is that while navigating through the schema, we are using the configured :version option as the validator for each partial schema. This is an issue because if the root of the schema declares a $schema, that information is lost in the traversal.

The refactor does two things. Firstly, it does not write back into @options[:version] and it stops using it outside of the constructor entirely. The only place that should know about this is the initialized schema, and from that point on, the canonical validator should be the schema object's validator since it makes a decision about which to use in its constructor. Now we can reduce complexity by using that validator in the :validate_schema option branch.

The other place that used :version is the schema_from_fragment method, which is where the bug exists. What we're doing here, instead of dealing with schemas and hashes during the iterator, is pulling the schema object out, digging through it using the fragments, and then wrapping the result in a schema using the base_schema's validator.

Tests have been included that demonstrate the problem.

dpatti and others added 2 commits April 2, 2019 13:00
This refactors some of `Validator` to fix an issue with validating a
fragment of an extended schema against a json object. The problem is
that while navigating through the schema, we are using the configured
`:version` option as the validator for each partial schema. This is an
issue because if the root of the schema declares a `$schema`, that
information is lost in the traversal.

The refactor does two things. Firstly, it does not write back into
`@options[:version]` and it stops using it outside of the constructor
entirely. The only place that should know about this is the initialized
schema, and from that point on, the canonical validator should be the
schema object's validator since it makes a decision about which to use
in its constructor. Now we can reduce complexity by using that validator
in the `:validate_schema` option branch.

The other place that used `:version` is the `schema_from_fragment`
method, which is where the bug exists. What we're doing here, instead of
dealing with schemas *and* hashes during the iterator, is pulling the
schema object out, digging through it using the fragments, and then
wrapping the result in a schema using the `base_schema`'s validator.

Tests have been included that demonstrate the problem.
@zdennis
Copy link
Contributor Author

zdennis commented Apr 15, 2019

We weren't sure if updating the common test-suite made sense so we're happy to take that commit off.

@pboling
Copy link

pboling commented Feb 14, 2021

#423 (comment)

@bastelfreak
Copy link
Member

thanks for the PR. I merged it in #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants