Made sure all validate methods go through the same call chain #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now when a schema is validated, we perform a different call path depending on which of the validate methods is called. Schema validation has it's own path too. I've changed this so everything is validated via `JSON::Validator#validate!`, all other validate methods ultimately call that. This means that the varied validate class methods on `Validator` are simplified and just add or remove validation options.
|
👍 +2 actually, I like tidy code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when a schema is validated, we perform a different call path
depending on which of the validate methods is called. Schema validation
has it's own path too.
I've changed this so everything is validated via
JSON::Validator#validate!, all other validate methods ultimately callthat. This means that the varied validate class methods on
Validatorare simplified and just add or remove validation options.