Only reprocess batch tallies when relevant contest fields change #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were reprocessing all jurisdictions' batch tallies files whenever we made a request to update contests. This can be pretty disruptive because it affects every jurisdiction. There are a few cases that we know don't actually impact the batch tallies at all, so we can skip reprocessing: - When the audit admin doesn't change the contests at all (e.g. if they click "Save & Next" on the contests form without changing anything - When the audit admin only changes the contest's jurisdiction list. Since batch tallies are specific to a single jurisdiction, adding or removing a jurisdiction will have no impact on other jurisdiction's batch tallies.
arsalansufi
approved these changes
Nov 14, 2024
jonahkagan
deleted the
jonah/reprocess-batch-tallies-only-when-needed
branch
kshen0
approved these changes
Nov 14, 2024
|
|
||
| def normalize_contest(contest): | ||
| contest = contest.copy() | ||
| # This field isn't sent from the client, its computed on the backend, so |
There was a problem hiding this comment.
Whoops, didn't get the email notification about this comment before merging 🤦 Doesn't feel worth a PR to fix
There was a problem hiding this comment.
No problem, I think I actually submitted 1 minute after your merge
| ] | ||
|
|
||
| for contest in election.contests: | ||
| db_session.delete(contest) |
There was a problem hiding this comment.
Why change this from the previous Contest.query.filter_by(election_id=election.id).delete()?
There was a problem hiding this comment.
Accessing election.contests on L348 just above causes the contests to be loaded into the ORM's cache, which caused a stale data error when later trying to delete and then commit the new contests. I honestly don't understand the error, but this fixed it and is functionally equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1977
Previously, we were reprocessing all jurisdictions' batch tallies files whenever we made a request to update contests. This can be pretty disruptive because it affects every jurisdiction.
There are a few cases that we know don't actually impact the batch tallies at all, so we can skip reprocessing: