version in code does not match that in tagged releases.

[gedw99]

the version is hardcoded but the tagged release does not match.

Here is where we hard code the version number.

https://github.com/vorlif/xspreak/blob/15a5c7eddac3fdc55e0550308581516aee9c491e/commands/root.go#L24C18-L24C18

Below it shows the wrong version number..

go install github.com/vorlif/[email protected]
 xspreak --version
xspreak version v0.9.0

common thing but annoying ..

So maybe just write a makefile target to do both so it does not happen again.
It would create the tag at the same time as updating the version that is hardcoded in the golang code.

ok I see your doing it in CI at https://github.com/vorlif/xspreak/blob/main/.github/workflows/release.yml

so modify this to do a sed update of that golang version line then ?

[vorlif]

Hi @gedw99,

Thanks for the report. I agree with you, it's not nice. I'll try to set the version number with #4 automatically.

[gedw99]

Thankyou . I will have a look.

[gedw99]

@vorlif yes it works for me here. thanks !!

The go install github.com/vorlif/[email protected] version of course still reports as xspreak version v0.9.0, but thats cool. If you want do a tagged release of v 0.11.0 and then go of for it or just leave it.

The go install from source reports version as xspreak version (devel), which is correct.

[vorlif]

Thank you.

If you install the latest version, the correct version number will be displayed:

go install github.com/vorlif/[email protected]