Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Passing ppo_epochs to dp_actor.py #346

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Conversation

jayl940712
Copy link
Contributor

See issue: #342

@vermouth1992
Copy link
Collaborator

Could you also modify dp_critic.py as well? Thanks!

@jayl940712
Copy link
Contributor Author

jayl940712 commented Feb 23, 2025

Could you also modify dp_critic.py as well? Thanks!

Updated!

@vermouth1992
Copy link
Collaborator

Could you perform formatting?

@jayl940712
Copy link
Contributor Author

Updated format fix with yapf.

@PeterSH6
Copy link
Collaborator

The failed yapf test is due a format error in the main batch.
Already fixed so we can merge it now.

@PeterSH6 PeterSH6 merged commit b4c13ce into volcengine:main Feb 25, 2025
11 of 12 checks passed
zpqiu pushed a commit to zpqiu/verl that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants