Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for CockroachDB #235

Closed
wants to merge 2 commits into from
Closed

Conversation

baitxo
Copy link

@baitxo baitxo commented Dec 22, 2017

We are planning to use SQLBoiler with CockroachDB and this PR adds support for it.

CockroachDB does not support all data types yet so I've modified the test schema accordingly.

Disclaimer: I'm pretty new to Go development ;)

@aarondl
Copy link
Member

aarondl commented Dec 22, 2017

I wish I had known that this was happening. The v3 (https://github.com/volatiletech/sqlboiler/tree/v3) code rewrites a lot of the driver functionality and I would have told you to use that as your base (it still works just fine it's parity with v2 code) probably :( :( We'll either have to port it now or later which is extra work. But it's still an undetermined amount of time away from actually becoming the master branch. Thoughts?

@baitxo
Copy link
Author

baitxo commented Dec 22, 2017

I will check the v3 out to stimate how much work is needed to port it. I will let you know ;)

@glerchundi
Copy link
Contributor

Great work @baitxo!

But it's still an undetermined amount of time away from actually becoming the master branch.

When you say undetermined we're talking about weeks or months? What about cutting alpha versions from v3/develop to start testing it out? In case that is an option and until it gets into beta/stable phase this PR could be developed against the march-expected (they are already pushing v2.0-alpha releases) cockroach version which supports JSON as well.

Putting this issue as a ref, which could lead to simplify templating code: cockroachdb/cockroach#20985

WDYT?

@aarondl
Copy link
Member

aarondl commented Dec 26, 2017

v3 is an alpha branch. It's never going to be broken, as features are developed in isolation and then merged. You could use it today and it should work fine. If there are bugs in it I'd take a look at them.

@baitxo
Copy link
Author

baitxo commented Jan 22, 2018

Hi @aarondl,

Sorry for the delay, I've been unable to work on this... I've already checked the V3 and will port it.

I'm closing this PR in favor of the new one.

@baitxo baitxo closed this Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants