Declare workspaceFolders support in server capabilities #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the recommended way to declare up-front that the server supports workspace folders and is interested in change notifications. Without this server capability set, the vscode-languageserver-node dependency tries to register for workspace change notifications dynamically with a 'client/registerCapability' request. If the client doesn't support dynamic capability registration and responds to that request with a MethodNotHandled JSONRPC error, the promise for the request is rejected which causes the server to exit.
|
Thanks! |
1 task
This was referenced Oct 26, 2023
Closed
Closed
Closed
This was referenced Oct 27, 2023
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the recommended way to declare up-front that the server supports workspace folders and is interested in change notifications. Without this server capability set, the vscode-languageserver-node dependency tries to register for workspace change notifications dynamically with a 'client/registerCapability' request. If the client doesn't support dynamic capability registration and responds to that request with a MethodNotHandled JSONRPC error, the promise for the request is rejected which causes the server to exit.
Also see this similar change in pyright microsoft/pyright#4666