Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save focus level on close #18

Closed
wants to merge 4 commits into from
Closed

Save focus level on close #18

wants to merge 4 commits into from

Conversation

ergl
Copy link
Contributor

@ergl ergl commented Dec 7, 2018

I often use deep trees, and currently every time you reopen void, the view gets reset to the home level. This makes it so the view stack and the current focus view are restored between runs. Maybe it's not the best way to things (just exposing fields with pub), but it might be helpful anyway.

The changes should work on existing documents, as all the new proto fields are optional, but I haven't done exhaustive testing of this.

@alok
Copy link
Contributor

alok commented Feb 5, 2019

If I run this, it seems to clear my current document (good thing I backed up). Other than that it seems to work, and it doesn't clear its own doc.

@ergl
Copy link
Contributor Author

ergl commented Feb 5, 2019

@alok Sorry to hear that! I should probably test this more. I did this change a long time ago and my document seems to work fine. Let me close it and I'll look at it again

@alok
Copy link
Contributor

alok commented Mar 19, 2019

@ergl How did you autogenerate data_model.rs with the updated changes? I poked around the protobuf crate and had trouble figuring it out.

@ergl
Copy link
Contributor Author

ergl commented Mar 19, 2019

I installed the protobuf-codegen plugin for protoc. Once you have that installed, doing protoc --rust_out src/pb/ include/model.proto should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants