-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sagemath: update to 10.0. #43659
sagemath: update to 10.0. #43659
Conversation
I really hoped they would include updated networkx in this release. I have been meaning to update |
Do you have a draft PR for updating |
I think I have a reasonable fix for 10.0.rc0 and it may even work for 9.8. Still testing. Hopefully I will be able to get this fix merged in time for sagemath 10.0, but if not we can patch our sagemath. |
See sagemath/sage#35584 for support of networkx 3.1 in sagemath. |
c04d7c6
to
7506551
Compare
As of now we need just two patches coming from upstream:
Hopefully both will be merged upstream for the upcoming 10.0 release. |
CI failure on i686, when checking linbox:
The exact same thing run in #42326 without any failure... |
Now CI failure on x86_64-musl, when checking linbox:
I've run check linbox many times and I haven't been lucky (unlucky?) to trigger any failure locally 🤷 |
Maybe these ci failures are not too serious? I will test locally built pr on x86_64-musl and aarch64-glibc soon. |
They could be random failures that depend on the seed -- unfortunately linbox check doesn't print the seed used for each test. Or else, this could be some weird race condition type of heisenbug which triggers under heavy load (i.e. github actions) but not in my box. |
On aarch64-glibc, this looks quite good: only a couple of timed outs with test=yes
I can test more completely from within installed sage. |
I've added maxima update from #36711 since sagemath is about to support it (sagemath/sage#35619 is moving and the patch they have works for me in x86_64 -- testing now in musl and i686). @jbgg are you still interested on maxima? I'll adopt the void package if you don't mind, so it's easier for me to track it. |
thanks! I'll test soon. |
|
On the contrary. I removed I think the simplest solution is to not remove the |
Hmm, what I meant is adding maxima-emacs to removed-pkgs: could that work? |
I don't know, maybe adding to conflicts, etc... but I think the empty transition pkg should be ok and the easiest solution, also so that we "prune" the old maxima-emacs from the repo (later we just remove and add to removed-pkgs)
Can you copy the full output for all the tests that fail? Have you tried running tests with |
Can you try building python3 natively? When built in cross, the configure step gives:
which then causes this Please have a look at this configure check --- if you get "no" there I expect your natively built python3 will work ok. If this works then the fix for cross building python3 is adding What about the failures in BTW: you can use xbps-src to run checks in selected files and/or with a chosen random seed. Just create a file
Add |
Rebuilding python3 natively, I see
pass with just |
opened a pr for python3. everything looks good to me :) |
Do you mind explicitly adding to the sagemath template a line like |
10.0 is released. Before merging, I want to have a look at sagemath/sage#35658 (support sphinx 7). Presumably it won't affect us since we don't build the documentation. |
Also: - disable sbcl on aarch64 - don't makedepends on emacs (avoid a nocross build dep) - move maxima-emacs files to main pkg
All checks passed. It turns out that we don't really need sagemath/sage#35658 so I'm removing it. @dkwo: maybe you want to test it on aarch64. |
Also: - support networkx 3.1 (sagemath#35584) - support linbox 1.7.0 (sagemath#35612) - support maxima 5.46.0 (sagemath#35619) - support sympy 1.12 (sagemath#35635)
Looks great! I expect all tests to pass also on aarch64, but won't be able to confirm until next week. |
@dkwo : did you get a chance to test? Shall we merge this as is? |
I will test tomorrow (I forgot that today is a holiday in the US). |
all tests are passing out of the box on aarch64 :) |
@leahneukirchen shall we merge this? |
This builds on top of #43225 for convenience.
Testing the changes
I've been following beta releases and now rc0 includes all of our patches 💪
All doctests pass with the version of packages in void except for
python-Babel
which must be updated (as in #43497) and is included here as part of #43225.I've switched my system sagemath to this version as everything seems to be working ok. The testsuite is 10-15% faster.
@dkwo: enjoy.