binutils update to 2.31.1; enable cross ada #4312

pullmoll · 2018-10-31T13:39:23Z

[ci skip]

Supersedes: #2813
Also see: #4154

We will have a chicken-egg problem with gcc for x86_64-musl:

Once cross-x86_64-linux-musl is built for x86_64, we need to (force) cross build gcc for x86_64-musl from a x86_64 environment with ./xbps-src -a x86_64-musl -f pkg gcc to get Ada going.

Only afterwards the cross builders using an x86_64-musl environment can also compile the cross-*musl* packages.

Got cross build for i686-musl and x86_64-musl working.
Now this needs review and we need to coordinate the steps required to get things done.

maxice8 · 2018-10-31T13:50:40Z

To avoid triggering CI [ci skip] needs to be in every commit

Signed-off-by: Jürgen Buchmüller <[email protected]>

pullmoll · 2018-10-31T16:56:06Z

Manual steps required to build gcc for x86_64-musl with gnat:

pick binutils-2.31.1, cross-vpkg-dummy-0.29_1, and cross-x86_64-linux-musl-0.29_1
set up an x86_64 environment on the x86_64-musl builder, i.e. ./xbps-src binary-bootstrap
build binutils, cross-vpkg-dummy and cross-x86_64-linux-musl on x86_64
cross build (forced) gcc-8.2.0_5 for x86_64-musl, i.e. ./xbps-src -a x86_64-musl -f pkg gcc
merge this PR and let the builders work

Once the cross compilers are done:

add gcc-ada and libada-devel to base-chroot{,-musl} templates and revbump or update
finally revbump gcc to have it built with its own gnat

Someone with access to the x86_64-musl builder will have to do this.

In case someone wants to bootstrap w/o a working gcc-ada in the host (e.g. void before gcc-8.2.0_5), you can still use -o ~ada,gnatboot when building gcc for x86_64 in the void bootstrap.

maxice8 · 2018-10-31T17:10:58Z

On Wed, Oct 31, 2018 at 10:05:37AM -0700, Jürgen Buchmüller wrote: Manual steps required to build `gcc` for `x86_64-musl` with gnat: 1) pick `binutils-2.31.1`, `cross-vpkg-dummy-0.29_1`, and `cross-x86_64-linux-musl-0.29_1` 2) set up an `x86_64` environment on the `x86_64-musl` builder, i.e. `./xbps-src binary-bootstrap` 3) build `binutils`, `cross-vpkg-dummy` and `cross-x86_64-linux-musl` on `x86_64` 4) cross build (forced) `gcc-8.2.0_5` for `x86_64-musl`, i.e. `./xbps-src -a x86_64-musl -f pkg gcc` 5) merge this PR and let the builders work Someone with access to the x86_64-musl builder will have to do this. In case someone wants to bootstrap w/o a working gcc-ada in the host (e.g. void before gcc-8.2.0_5), you can still use `-o ~ada,gnatboot` when building gcc for x86_64 in the void bootstrap. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #4312 (comment)

@void-linux/pkg-committers

pullmoll · 2018-10-31T17:38:13Z

Uhm, just now, when trying to rebuild gcc for i686, it strikes me that our build system can not use a previous version of gcc-ada and libada-devel when building gcc native.

If I add gcc-ada and libada-devel to the hostmakedepends of gcc also for native builds, this results in a short circuit because those packages are just about to be built. Can we do anything to support this kind of use any previous package or even use a specific previous package dependency?

Thinking about it we could probably use the cross compiler's gnat similar to how gnatboot does it, but we have no cross-x86_64-linux-gnu package.

Or do we have to make gcc-ada and libada-devel part of the base-chroot{,-musl} to always have it available?

Edit2: Last not least we could perhaps integrate gcc-ada and libada* with gcc like we did once with g++.

Vaelatern · 2018-10-31T19:52:25Z

Sadly xbps-src doesn't know how to do this.

ghost · 2018-11-03T11:59:10Z

patches for binutils 2.31.1?

pullmoll · 2018-11-03T12:31:27Z

@protonesso what patches?

ghost · 2018-11-03T13:04:40Z

https://www.openwall.com/lists/musl/2018/07/18/5

pullmoll · 2018-11-03T14:03:14Z

No problem here inside a chroot with x86_64-musl:

[jbu@/tmp/void/muslc-3 builddir]$ cat test.c
int main() { return 0; }
[jbu@/tmp/void/muslc-3 builddir]$ gcc -ggdb3 -O0 -static test.c
[jbu@/tmp/void/muslc-3 builddir]$ gdb ./a.out
GNU gdb (GDB) 8.1.1
[... snip ...]
Reading symbols from ./a.out...done.
(gdb) run
Starting program: /builddir/a.out 
[Inferior 1 (process 863) exited normally]
(gdb)

ghost · 2018-11-03T14:07:52Z

oh okay

pullmoll · 2018-11-06T23:33:27Z

Updated to _linux_version=4.19 for the kernel-libc-headers

Is anyone of @void-linux/void-ops around to help go through the steps listed above?

pullmoll · 2018-11-10T14:47:44Z

ping @void-linux/void-ops

Gottox · 2018-11-10T18:31:14Z

Afaics this breaks the build of new packages, but there's no point where we run time is broken. Do I understand this correctly? If so, we can schedule the rebuild and let the maintainers know not to push to master in that time frame.

Gottox · 2018-11-10T18:33:02Z

Is Wednesday evening CET okay?

maxice8 · 2018-11-10T18:39:36Z

Please give a time range with timezone

…

On Sat, Nov 10, 2018, 16:33 Enno Boland ***@***.*** wrote: Is wednesday evening CET okay? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4312 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AdUHTdmeF_u3n9YOrveQS0r_IMDudTdWks5utxvfgaJpZM4YEGGq> .

pullmoll · 2018-11-10T19:36:20Z

I don't believe it will break anything. In fact you can even just cross compile gcc for x86_64-musl without -f to create gcc-ada-8.2.0_5.x86_64-musl.xbps, libada-8.2.0_5.x86_64-musl.xbps, and libada-devel-8.2.0_5.x86_64-musl.xbps.
Once these pkgs are available all cross compilers can be built and we can add gcc-ada and libada-devel to the templates for base-chroot and base-chroot-musl and revbump. Still no breakage here and this will also fix bootstrapping.

FWIW Wednesday evening is ok for me. I'll join the xbps channel just in case.

Gottox · 2018-11-18T22:07:05Z

1) pick binutils-2.31.1, cross-vpkg-dummy-0.29_1, and cross-x86_64-linux-musl-0.29_1
2) set up an x86_64 environment on the x86_64-musl builder, i.e. ./xbps-src binary-bootstrap
3) build binutils, cross-vpkg-dummy and cross-x86_64-linux-musl on x86_64
4) cross build (forced) gcc-8.2.0_5 for x86_64-musl, i.e. ./xbps-src -a x86_64-musl -f pkg gcc
5) merge this PR and let the builders work

Once the cross compilers are done:

6) add gcc-ada and libada-devel to base-chroot{,-musl} templates and revbump or update
7) finally revbump gcc to have it built with its own gnat

Gottox · 2018-11-18T22:17:35Z

cross-x86_64-linux-musl

=> Building Linux API headers
patching file include/uapi/linux/kernel.h
Hunk #1 succeeded at 2 (offset 1 line).
patching file include/uapi/linux/libc-compat.h
Hunk #1 FAILED at 165.
Hunk #2 succeeded at 262 with fuzz 2 (offset 54 lines).
1 out of 2 hunks FAILED -- saving rejects to file include/uapi/linux/libc-compat.h.rej
=> ERROR: cross-x86_64-linux-musl-0.29_1: do_build: 'patch -N $args -i $2' exited with 1
=> ERROR:   in _apply_patch() at srcpkgs/cross-x86_64-linux-musl/template:44
=> ERROR:   in _linux_headers() at srcpkgs/cross-x86_64-linux-musl/template:134
=> ERROR:   in do_build() at srcpkgs/cross-x86_64-linux-musl/template:211

Gottox · 2018-11-18T22:37:09Z

fixed by rebasing against master.

[ci skip]

pullmoll · 2018-11-18T23:26:55Z

Rebased my branch before going to bed :)

Gottox · 2018-11-19T08:06:18Z

Thanks a lot :)

Yet another one on cross-x86_64-linux-musl:

gcc -I../../../gcc-8.2.0/libgcc/. -I../../../gcc-8.2.0/libgcc/../gcc -I../../../gcc-8.2.0/libgcc/../include  -DHAVE_CC_TLS  -DUSE_TLS -o unwind-sjlj.o -MT unwind-sjlj.o -MD -MP 
-MF unwind-sjlj.dep -fexceptions -c ../../../gcc-8.2.0/libgcc/unwind-sjlj.c -fvisibility=hidden -DHIDE_EXPORTS
/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/./gcc/xgcc -B/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/./gcc/ -B/usr/x86_64-linux-musl/bin/ -B/usr/x86_64-linux-m
usl/lib/ -isystem /usr/x86_64-linux-musl/include -isystem /usr/x86_64-linux-musl/sys-include    -g -O2 -fPIC -D__WCHAR_TYPE__=int -m32 -O2  -g -O2 -fPIC -D__WCHAR_TYPE__=int -DI
N_GCC  -DCROSS_DIRECTORY_STRUCTURE  -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition  -isystem ./include   -fP
IC -mlong-double-80 -DUSE_ELF_SYMVER  -g -DIN_LIBGCC2 -fbuilding-libgcc -fno-stack-protector   -fPIC -mlong-double-80 -DUSE_ELF_SYMVER  -I. -I. -I../../.././gcc -I../../../../gc
c-8.2.0/libgcc -I../../../../gcc-8.2.0/libgcc/. -I../../../../gcc-8.2.0/libgcc/../gcc -I../../../../gcc-8.2.0/libgcc/../include  -DHAVE_CC_TLS  -DUSE_TLS -o sse_resms64fx_s.o -M
T sse_resms64fx_s.o -MD -MP -MF sse_resms64fx_s.dep -DSHARED -c -xassembler-with-cpp ../../../../gcc-8.2.0/libgcc/config/i386/sse_resms64fx.S
<command-line>: warning: "__WCHAR_TYPE__" redefined
<built-in>: note: this is the location of the previous definition
/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/./gcc/xgcc -B/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/./gcc/ -B/usr/x86_64-linux-musl/bin/ -B/usr/x86_64-linux-musl/lib/ -isystem /usr/x86_64-linux-musl/include -isystem /usr/x86_64-linux-musl/sys-include    -g -O2 -fPIC -D__WCHAR_TYPE__=int -m32 -O2  -g -O2 -fPIC -D__WCHAR_TYPE__=int -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition  -isystem ./include   -fPIC -mlong-double-80 -DUSE_ELF_SYMVER  -g -DIN_LIBGCC2 -fbuilding-libgcc -fno-stack-protector   -fPIC -mlong-double-80 -DUSE_ELF_SYMVER  -I. -I. -I../../.././gcc -I../../../../gcc-8.2.0/libgcc -I../../../../gcc-8.2.0/libgcc/. -I../../../../gcc-8.2.0/libgcc/../gcc -I../../../../gcc-8.2.0/libgcc/../include  -DHAVE_CC_TLS  -DUSE_TLS -o generic-morestack.o -MT generic-morestack.o -MD -MP -MF generic-morestack.dep  -c ../../../../gcc-8.2.0/libgcc/generic-morestack.c -fvisibility=hidden -DHIDE_EXPORTS
<command-line>: warning: "__WCHAR_TYPE__" redefined
<built-in>: note: this is the location of the previous definition
In file included from /usr/x86_64-linux-musl/include/stdio.h:22,
                 from ../../../../gcc-8.2.0/libgcc/../gcc/tsystem.h:87,
                 from ../../../../gcc-8.2.0/libgcc/generic-morestack.c:30:
/usr/x86_64-linux-musl/include/bits/alltypes.h:101:24: error: conflicting types for 'size_t'
 typedef unsigned _Addr size_t;
                        ^~~~~~
In file included from ../../../../gcc-8.2.0/libgcc/../gcc/tsystem.h:44,
                 from ../../../../gcc-8.2.0/libgcc/generic-morestack.c:30:
/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/gcc/include/stddef.h:216:23: note: previous declaration of 'size_t' was here
 typedef __SIZE_TYPE__ size_t;
                       ^~~~~~
/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/./gcc/xgcc -B/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/./gcc/ -B/usr/x86_64-linux-musl/bin/ -B/usr/x86_64-linux-musl/lib/ -isystem /usr/x86_64-linux-musl/include -isystem /usr/x86_64-linux-musl/sys-include    -g -O2 -fPIC -D__WCHAR_TYPE__=int -O2  -g -O2 -fPIC -D__WCHAR_TYPE__=int -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition  -isystem ./include   -fPIC -mlong-double-80 -DUSE_ELF_SYMVER  -g -DIN_LIBGCC2 -fbuilding-libgcc -fno-stack-protector   -fPIC -mlong-double-80 -DUSE_ELF_SYMVER  -I. -I. -I../.././gcc -I../../../gcc-8.2.0/libgcc -I../../../gcc-8.2.0/libgcc/. -I../../../gcc-8.2.0/libgcc/../gcc -I../../../gcc-8.2.0/libgcc/../include  -DHAVE_CC_TLS  -DUSE_TLS -o emutls.o -MT emutls.o -MD -MP -MF emutls.dep -fexceptions -c ../../../gcc-8.2.0/libgcc/emutls.c -fvisibility=hidden -DHIDE_EXPORTS
make[4]: *** [../../../../gcc-8.2.0/libgcc/static-object.mk:17: generic-morestack.o] Error 1
make[4]: Leaving directory '/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/x86_64-linux-musl/32/libgcc'
make[3]: *** [Makefile:1201: multi-do] Error 1
make[3]: Leaving directory '/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/x86_64-linux-musl/libgcc'
make[2]: *** [Makefile:125: all-multi] Error 2
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap/x86_64-linux-musl/libgcc'
make[1]: *** [Makefile:11672: all-target-libgcc] Error 2
make[1]: Leaving directory '/builddir/cross-x86_64-linux-musl-0.29/gcc-bootstrap'
make: *** [Makefile:885: all] Error 2
=> ERROR: cross-x86_64-linux-musl-0.29_1: do_build: 'make ${makejobs}' exited with 2
=> ERROR:   in _gcc_bootstrap() at srcpkgs/cross-x86_64-linux-musl/template:119
=> ERROR:   in do_build() at srcpkgs/cross-x86_64-linux-musl/template:211

pullmoll · 2018-11-19T08:18:20Z

This is strange because it builds just fine here. Verified just now.
Can you zap and binary-bootstrap x86_64-musl again to make sure you have the latest packages?
I'll try the build with the official repository's packages.

Gottox · 2018-11-19T08:28:10Z

I'm currently building on x86_64 for step 3).

pullmoll · 2018-11-19T09:13:41Z

Oh, yes, of course on x86_64.

Gottox · 2018-11-19T10:15:52Z

Having a freshly bootstrapped masterdir fixed the issue. something in the build progress taints the masterdir.

Gottox · 2018-11-19T15:03:16Z

@pullmoll https://build.voidlinux.eu/builders/x86_64-musl_builder/builds/14974/steps/shell_3/logs/stdio

pullmoll · 2018-11-19T15:10:21Z

Darn. The main gcc is not aware of GNAT because it has not been rebuilt.
Can you force cross build it once more, i.e. also rebuild gcc-8.2.0_5-x86_64-musl.xbps?

pullmoll · 2018-11-19T15:11:18Z

My guess that a build without -f should be sufficient was wrong :P

Gottox · 2018-11-19T15:23:29Z

Might be my mistake, I haven't cleaned up the masterdir.

Gottox · 2018-11-19T15:23:46Z

Hope and wait.

Gottox · 2018-11-19T15:24:27Z

https://build.voidlinux.eu/builders/x86_64-musl_builder/builds/14975/steps/shell_3/logs/stdio yet another one.

Gottox · 2018-11-19T15:25:33Z

https://bugzilla.redhat.com/show_bug.cgi?id=1552529#c1 okay, something went wront with binutils.

pullmoll · 2018-11-19T15:32:15Z

Is the builder itself bootstrapped? binutils is in base-chroot-musl.
BTW cannot connect to chat.freenode.net for some reason.

Gottox · 2018-11-19T15:34:47Z

Ah, I see, I think I've got the error.

Gottox · 2018-11-19T15:39:34Z

The old binutils got installed again.

Gottox · 2018-11-19T15:51:19Z

Looks promising 👍

pullmoll · 2018-11-19T16:03:53Z

Yes, thank you. I think the gcc revbump needs to happen before the base-chroot{,-musl} update because the latter requires gcc-ada, libada{,-devel} having been built for each architecture.

pullmoll · 2018-11-19T16:04:47Z

I.e. step 7) before 6)

Gottox · 2018-11-19T16:05:32Z

👍 wilco

pullmoll · 2018-11-19T16:09:35Z

OTOH gcc-ada is required w/o hostmakedpends for the native builds of gcc.
Perhaps let the cross built gcc fail once and then succeed once the base-chroot{,-musl} is done for native.

Gottox · 2018-11-19T16:12:59Z

Great, will update once the build has finished. Thanks!

pullmoll · 2018-11-19T16:15:09Z

I'm away from keyboard for some time now. Hope you can manage the remaining steps. 🍺

pullmoll · 2018-11-19T22:59:19Z

@chneukirchen If the aarch64{,-musl} builders are still using their own x86_64 packages, which I believe they do, they need to be updated manually. In the host build binutils, cross-aarch64-linux-{gnu,musl}, and cross-vpkg-dummy.

Gottox · 2018-11-20T06:08:00Z

Why add ada to base-chroot at all? - The only compiler it has included is gcc.

pullmoll · 2018-11-20T08:56:34Z

Because gcc needs gcc-ada in the host to build ada.
The only way to avoid the (impossible to break) circular dependency is to always have the previous gcc-ada available.

pullmoll added the WIP Work in progress label Oct 31, 2018

pullmoll referenced this pull request Oct 31, 2018

gcc: fix order of subpackages again

73ae655

Signed-off-by: Jürgen Buchmüller <[email protected]>

pullmoll removed the WIP Work in progress label Oct 31, 2018

pullmoll changed the title ~~[WIP] binutils update to 2.31.1; enable cross ada~~ binutils update to 2.31.1; enable cross ada Oct 31, 2018

pullmoll mentioned this pull request Nov 6, 2018

Cross built rustc missing symbol crc32 #4379

Closed

pullmoll mentioned this pull request Nov 17, 2018

fuse-exfat-1.3.0_1 won't mount drives with udevil #2928

Closed

pullmoll added 5 commits November 19, 2018 00:26

binutils: update to 2.31.1

0340090

[ci skip]

cross-aarch64-linux-gnu: binutils-2.31.1 and gnat

2f42dde

[ci skip]

cross-aarch64-linux-musl: binutils-2.31.1 and gnat

36731ef

[ci skip]

cross-arm-linux-gnueabi: binutils-2.31.1 and gnat

529af6f

[ci skip]

cross-arm-linux-gnueabihf: binutils-2.31.1 and gnat

43690e0

[ci skip]

cross-x86_64-linux-musl: binutils-2.31.1 and gnat

be25c20

[ci skip]

Gottox merged commit e649ccd into void-linux:master Nov 19, 2018

pullmoll deleted the ada branch November 20, 2018 10:00

ghost mentioned this pull request Feb 26, 2021

gnat/gcc-ada mmatongo/kiss-lang#2

Open

binutils update to 2.31.1; enable cross ada #4312

binutils update to 2.31.1; enable cross ada #4312

Conversation

pullmoll commented Oct 31, 2018 • edited Loading

maxice8 commented Oct 31, 2018

pullmoll commented Oct 31, 2018 • edited Loading

maxice8 commented Oct 31, 2018 via email • edited Loading

pullmoll commented Oct 31, 2018 • edited Loading

Vaelatern commented Oct 31, 2018

ghost commented Nov 3, 2018

pullmoll commented Nov 3, 2018

ghost commented Nov 3, 2018

pullmoll commented Nov 3, 2018

ghost commented Nov 3, 2018

pullmoll commented Nov 6, 2018 • edited Loading

pullmoll commented Nov 10, 2018

Gottox commented Nov 10, 2018

Gottox commented Nov 10, 2018 • edited Loading

maxice8 commented Nov 10, 2018 via email

pullmoll commented Nov 10, 2018

Gottox commented Nov 18, 2018 • edited Loading

Gottox commented Nov 18, 2018

Gottox commented Nov 18, 2018

pullmoll commented Nov 18, 2018

Gottox commented Nov 19, 2018

pullmoll commented Nov 19, 2018 • edited Loading

Gottox commented Nov 19, 2018

pullmoll commented Nov 19, 2018

Gottox commented Nov 19, 2018

Gottox commented Nov 19, 2018

pullmoll commented Nov 19, 2018

pullmoll commented Nov 19, 2018

Gottox commented Nov 19, 2018

Gottox commented Nov 19, 2018

Gottox commented Nov 19, 2018

Gottox commented Nov 19, 2018 • edited Loading

pullmoll commented Nov 19, 2018 • edited Loading

Gottox commented Nov 19, 2018

Gottox commented Nov 19, 2018

Gottox commented Nov 19, 2018

pullmoll commented Nov 19, 2018

pullmoll commented Nov 19, 2018

Gottox commented Nov 19, 2018

pullmoll commented Nov 19, 2018

Gottox commented Nov 19, 2018

pullmoll commented Nov 19, 2018

pullmoll commented Nov 19, 2018

Gottox commented Nov 20, 2018

pullmoll commented Nov 20, 2018

pullmoll commented Oct 31, 2018 •

edited

Loading

pullmoll commented Oct 31, 2018 •

edited

Loading

maxice8 commented Oct 31, 2018 via email •

edited

Loading

pullmoll commented Oct 31, 2018 •

edited

Loading

pullmoll commented Nov 6, 2018 •

edited

Loading

Gottox commented Nov 10, 2018 •

edited

Loading

Gottox commented Nov 18, 2018 •

edited

Loading

pullmoll commented Nov 19, 2018 •

edited

Loading

Gottox commented Nov 19, 2018 •

edited

Loading

pullmoll commented Nov 19, 2018 •

edited

Loading