Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/translations #96

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Fix/translations #96

merged 2 commits into from
Jan 23, 2022

Conversation

luwol03
Copy link
Member

@luwol03 luwol03 commented Jan 23, 2022

Status Type
✅ Ready Bug

Description

  • fixes an error if a user sets the language to german and then opens the selection screen. This is related to localazy and its exporting behavier of arrays with only one element.
  • adds translations to the headlines in the add package/group modals which are accessed from within the add vocab page.

Motivation and Context

Screenshots / GIFs (if appropriate):

Checklist

  • I have read the CONTRIBUTING document.
  • I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
  • I have documented my code if needed

Resolves

@luwol03 luwol03 added kind/bug Something isn't working kind/translations labels Jan 23, 2022
@luwol03 luwol03 added this to the v1.3.0 milestone Jan 23, 2022
@luwol03 luwol03 requested a review from noctera January 23, 2022 13:17
@luwol03 luwol03 self-assigned this Jan 23, 2022
@luwol03 luwol03 merged commit 6007503 into experimental Jan 23, 2022
@luwol03 luwol03 deleted the fix/translations branch January 23, 2022 14:16
@luwol03 luwol03 modified the milestones: v1.3.0, v1.2.1 Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/translations
Projects
Status: 🚀 Ready
Development

Successfully merging this pull request may close these issues.

2 participants