Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: language selector options visibility #73

Merged
merged 1 commit into from
Jun 11, 2021
Merged

fix: language selector options visibility #73

merged 1 commit into from
Jun 11, 2021

Conversation

zikowang
Copy link
Contributor

@zikowang zikowang commented Jun 11, 2021 •
edited by luwol03
Loading

Status Type
✅ Hotfix

Description

Motivation and Context

Bug: The select options of the LanguageSelect component is not fully visible in its modal.
This PR fixes that bug.

Screenshots / GIFs (if appropriate):

Before

After

Checklist

  • I have read the CONTRIBUTING document.
  • I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
  • I have documented my code if needed

Resolves

@zikowang zikowang requested a review from luwol03 June 11, 2021 14:38
@luwol03 luwol03 merged commit aaada8a into experimental Jun 11, 2021
@luwol03 luwol03 deleted the fix-language-selector branch June 11, 2021 15:50
@luwol03 luwol03 modified the milestones: v1.0.0, v1.1.0 Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noctera noctera noctera approved these changes

@luwol03 luwol03 luwol03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Todo
Status: 🚀 Ready
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zikowang @noctera @luwol03