Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vocabsearch to "All Vocabs" screen #110

Merged
merged 5 commits into from
Apr 24, 2022

Conversation

Tracer1337
Copy link
Member

@Tracer1337 Tracer1337 commented Apr 19, 2022

Status Type
✅ Ready Feature

Description

Added vocab search to "All Vocabs" screen.

Bug on server: Only matching translations are returned which results in incomplete vocabulary cards (look for "Peanuts, Treenuts" in the GIF)

Screenshots / GIFs (if appropriate):

Animation

Resolves

fixes #108

@Tracer1337 Tracer1337 mentioned this pull request Apr 19, 2022
@luwol03
Copy link
Member

luwol03 commented Apr 19, 2022

Thank you for your pull request.
Please remove your translations. Change only the en/default.json if necessary.
If this pull request is merged into the experimental branch, it can be translated via localazy.

Please remove following files from pull request changes.

- src/i18n/locales/de/default.json

(posted on behalf of @VocascanBot )

@luwol03 luwol03 self-assigned this Apr 19, 2022
@luwol03 luwol03 added the kind/enhancement New feature or request label Apr 19, 2022
@luwol03 luwol03 added this to the v1.3.0 milestone Apr 19, 2022
@Tracer1337
Copy link
Member Author

Thank you for your pull request. Please remove your translations. Change only the en/default.json if necessary. If this pull request is merged into the experimental branch, it can be translated via localazy.

Please remove following files from pull request changes.

- src/i18n/locales/de/default.json

(posted on behalf of @VocascanBot )

Its removed

Copy link
Member

@luwol03 luwol03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @noctera can we merge this?

@noctera
Copy link
Member

noctera commented Apr 24, 2022

Yes we can merge it

@luwol03 luwol03 merged commit 17d2bd9 into vocascan:experimental Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: 🚀 Ready
Development

Successfully merging this pull request may close these issues.

3 participants