vdk-impala: fixed platform error missclasified when running template #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <[email protected]>
antoniivanov
approved these changes
Aug 19, 2022
added 3 commits
August 25, 2022 17:37
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: Fixed a wrongly classified platform error which is supposed to be handled by users. We were throwing the base exception class for this error whereas we should have been throwing a user error. Changed the implementation to use the errors.log_and_rethrow method.
why: Users executing templates were receiving an unhelpfull error message and a data job that terminated in Platform Error due to us throwing the most base Exception class from within the template.
testing: modified existing unit test.
Signed-off-by: Momchil Zhivkov [email protected]