Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-ingest-http: reduce verbosity of ingestion logs #943

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

antoniivanov
Copy link
Collaborator

Logging each payload at INFO is extremely verbose, we can have thousands
and thousands of payloads being sent. So it also slows down teh
ingestion.

Signed-off-by: Antoni Ivanov [email protected]

Logging each payload at INFO is extremely verbose, we can have thousands
and thousands of payloads being sent. So it also slows down teh
ingestion.

Signed-off-by: Antoni Ivanov <[email protected]>
Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm;

On the logging topic, we have ~50 vdk built-in/internal loggers; maybe we may consider a plugin for (text-)configurable logging level per logger. The use case is, a data analyst would like to increase vdk.internal.builtin_plugins.ingestion logging when developing on local machine. So when configured, the vdk config will be stored, and applied to each data job local run.

@antoniivanov
Copy link
Collaborator Author

ltgm;

On the logging topic, we have ~50 vdk built-in/internal loggers; maybe we may consider a plugin for (text-)configurable logging level per logger. The use case is, a data analyst would like to increase vdk.internal.builtin_plugins.ingestion logging when developing on local machine. So when configured, the vdk config will be stored, and applied to each data job local run.

Yes. I've thought about this. we currently wehave LOG_LEVEL_VDK config -

But maybe we can make it more genric -e.g LOG_LEVEL=vdk.api=INFO,vdk.internal=WARNING
(Similar to how in spring you can set logging.level.com.domain=INFO

@antoniivanov antoniivanov merged commit 361b258 into main Aug 18, 2022
@antoniivanov antoniivanov deleted the person/aivanov/vdk-ingest branch August 18, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants