vdk-core: template running state detection capability #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since template executions are autonomous data job runs, we need to be able to determine if a template is running at any time. For example, to distinguish between root data job finalization, and template finalization. A template running boolean state introduced. Example usage is: `core_context.state.get(ExecutionStateStoreKeys.TEMPLATE_RUNNING)` Testing Done: added `test_template_running_state` coverage. Signed-off-by: ikoleva <[email protected]>
antoniivanov
requested changes
Aug 17, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/templates/template_impl.py
Outdated
Show resolved
Hide resolved
Since template executions are autonomous data job runs, we need to be able to determine if a template is running at any time. For example, to distinguish between root data job finalization, and template finalization. A template running name,args optional tuple state introduced. Example usage is: `core_context.state.get(ExecutionStateStoreKeys.TEMPLATE_RUNNING)` Testing Done: added `test_template_running_state` coverage. Signed-off-by: ikoleva <[email protected]>
Since template executions are autonomous data job runs, we need to be able to determine if a template is running at any time. For example, to distinguish between root data job finalization, and template finalization. A template name optional state introduced. Example usage is: `core_context.state.get(ExecutionStateStoreKeys.TEMPLATE_NAME)` If the data job has been spawned by a template execution, the name of the template is then retrieved. Otherwise, no template name is set. Testing Done: added `test_template_name_not_set` and `test_template_name_set` coverage. Signed-off-by: ikoleva <[email protected]>
Since template executions are autonomous data job runs, we need to be able to determine if a template is running at any time. For example, to distinguish between root data job finalization, and template finalization. A template name optional state introduced. Example usage is: `core_context.state.get(ExecutionStateStoreKeys.TEMPLATE_NAME)` If the data job has been spawned by a template execution, the name of the template is then retrieved. Otherwise, no template name is set. Testing Done: added `test_template_name_not_set` and `test_template_name_set` coverage. Signed-off-by: ikoleva <[email protected]>
Since template executions are autonomous data job runs, we need to be able to determine if a template is running at any time. For example, to distinguish between root data job finalization, and template finalization. A template name optional state introduced. Example usage is: `core_context.state.get(ExecutionStateStoreKeys.TEMPLATE_NAME)` If the data job has been spawned by a template execution, the name of the template is then retrieved. Otherwise, no template name is set. Testing Done: added `test_run_not_from_template`, `test_run_from_template`, `test_standalone_data_job_not_from_template and `test_standalone_data_job_from_template` coverage. Signed-off-by: ikoleva <[email protected]>
Since template executions are autonomous data job runs, we need to be able to determine if a template is running at any time. For example, to distinguish between root data job finalization, and template finalization. A template name optional state introduced. Example usage is: `core_context.state.get(ExecutionStateStoreKeys.TEMPLATE_NAME)` If the data job has been spawned by a template execution, the name of the template is then retrieved. Otherwise, no template name is set. Testing Done: added `test_run_not_from_template`, `test_run_from_template`, `test_standalone_data_job_not_from_template and `test_standalone_data_job_from_template` coverage. Signed-off-by: ikoleva <[email protected]>
Since template executions are autonomous data job runs, we need to be able to determine if a template is running at any time. For example, to distinguish between root data job finalization, and template finalization. A template name optional state introduced. Example usage is: `core_context.state.get(ExecutionStateStoreKeys.TEMPLATE_NAME)` If the data job has been spawned by a template execution, the name of the template is then retrieved. Otherwise, no template name is set. Testing Done: added `test_run_not_from_template`, `test_run_from_template`, `test_standalone_data_job_not_from_template and `test_standalone_data_job_from_template` coverage. Signed-off-by: ikoleva <[email protected]>
antoniivanov
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vdk-core: template running state detection capability
Since template executions are autonomous data job runs, we need
to be able to determine if a template is running at any time.
For example, to distinguish between root data job finalization, and
template finalization.
A template name optional state introduced.
Example usage is:
core_context.state.get(ExecutionStateStoreKeys.TEMPLATE_NAME)If the data job has been spawned by a template execution, the name of
the template is then retrieved. Otherwise, no template name is set.
Testing Done: added
test_run_not_from_template,test_run_from_template,test_standalone_data_job_not_from_templateand
test_standalone_data_job_from_templatecoverage.Signed-off-by: ikoleva [email protected]