vdk-core: step loading failure misclassified as Platform error fix #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cases of any data job step source cannot be loaded, due to syntax error, or issue with importing dependency, were misclassified as Platform error. Failure to load step source, is now classified correctly as User error. Testing Done: added a test to cover the use-case. Signed-off-by: ikoleva <[email protected]>
Cases of any data job step source cannot be loaded, due to syntax error, or issue with importing dependency, were misclassified as Platform error. Failure to load step source, is now classified correctly as User error. Testing Done: added a test to cover the use-case. Signed-off-by: ikoleva <[email protected]>
doks5
approved these changes
Jul 28, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/run/file_based_step.py
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/run/file_based_step.py
Show resolved
Hide resolved
Cases of any data job step source cannot be loaded, due to syntax error, or issue with importing dependency, were misclassified as Platform error. Failure to load step source, is now classified correctly as User error. Testing Done: added a test to cover the use-case. Signed-off-by: ikoleva <[email protected]>
…ure-misclassified-fix' into person/ikoleva/step-loading-failure-misclassified-fix
ivakoleva
deleted the
person/ikoleva/step-loading-failure-misclassified-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases of any data job step source cannot be loaded, due to syntax error,
or issue with importing dependency, were misclassified as
Platform error.
Failure to load step source, is now classified correctly as User error.
Testing Done: added a test to cover the use-case.