vdk-trino: fix broken tests #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent change in trino library broke our tests - After trinodb/trino#9129 trino would fail `drop view if not exists` query if table with that name exists instead of silently proceeding. which is problem for us since our tests seem to rely on us they execute both drop view and drop table to make sure a table or view is deleted. So now I am pinning to old version of trino to hopefully fix the issue as a quick workaround. Will create separate ticket to fix it in a way that works against latest version of trino. Testing Done: this PR CICD :) Signed-off-by: Antoni Ivanov <[email protected]>
doks5
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent change in trino library broke our tests -
After trinodb/trino#9129 trino would fail
drop view if not existsquery if table with that name exists insteadof silently proceeding.
which is problem for us since our tests seem to rely on us they execute
both drop view and drop table to make sure a table or view is deleted.
So now I am pinning to old version of trino to hopefully fix the issue
as a quick workaround. Will create separate ticket to fix it in a way
that works against latest version of trino.
Testing Done: this PR CICD :)
Signed-off-by: Antoni Ivanov [email protected]