Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-kerberos-auth: add KerberosClient for authenticating API calls #879

Merged
merged 12 commits into from
Sep 5, 2022

Conversation

antoniivanov
Copy link
Collaborator

We are adding support for Kerberos authentication in the Control REST
API . This is extending the support for the client to be able to make
authentication requests with kerberos.

This is part 1 adding KerberosClient "API" for the purpose of clients
using it to get Kerberos authentication header.

In a follow-up MR I will adopt it in vdk-control-cli

Testing Done: automated tests

Signed-off-by: Antoni Ivanov [email protected]

@antoniivanov antoniivanov force-pushed the person/aivanov/vdk-kerberos-auth branch from 157d24d to d71acdd Compare August 23, 2022 19:51
antoniivanov and others added 10 commits August 29, 2022 12:57
We are adding support for Kerberos authentication in the Control REST
API . This is extending the support for the client to be able to make
authentication requests with kerberos.

This is part 1 adding KerberosClient "API" for the purpose of clients
using it to get Kerberos authentication header.

In a follow-up MR I will adopt it in vdk-control-cli

Testing Done: automated tests

Signed-off-by: Antoni Ivanov <[email protected]>
…/api/kerberos_client.py

Co-authored-by: Gabriel Georgiev <[email protected]>
We are adding support for Kerberos authentication in the Control REST
API . This is extending the support for the client to be able to make
authentication requests with kerberos.

This is part 1 adding KerberosClient "API" for the purpose of clients
using it to get Kerberos authentication header.

In a follow-up MR I will adopt it in vdk-control-cli

Testing Done: automated tests

Signed-off-by: Antoni Ivanov <[email protected]>
@antoniivanov antoniivanov force-pushed the person/aivanov/vdk-kerberos-auth branch from d5c545f to 6f53109 Compare August 29, 2022 09:57
Copy link
Contributor

@mrMoZ1 mrMoZ1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge after all tests pass.

@antoniivanov antoniivanov enabled auto-merge (squash) September 2, 2022 14:45
@antoniivanov antoniivanov merged commit 45c1c08 into main Sep 5, 2022
@antoniivanov antoniivanov deleted the person/aivanov/vdk-kerberos-auth branch September 5, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants