-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdk-kerberos-auth: add KerberosClient for authenticating API calls #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/api/kerberos_client.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/api/kerberos_client.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/api/kerberos_client.py
Outdated
Show resolved
Hide resolved
doks5
reviewed
Jul 6, 2022
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/kerberos_ticket.py
Outdated
Show resolved
Hide resolved
157d24d
to
d71acdd
Compare
mrMoZ1
reviewed
Aug 26, 2022
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/api/kerberos_client.py
Outdated
Show resolved
Hide resolved
mrMoZ1
reviewed
Aug 26, 2022
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/kerberos_ticket.py
Outdated
Show resolved
Hide resolved
We are adding support for Kerberos authentication in the Control REST API . This is extending the support for the client to be able to make authentication requests with kerberos. This is part 1 adding KerberosClient "API" for the purpose of clients using it to get Kerberos authentication header. In a follow-up MR I will adopt it in vdk-control-cli Testing Done: automated tests Signed-off-by: Antoni Ivanov <[email protected]>
Co-authored-by: Gabriel Georgiev <[email protected]>
Co-authored-by: Gabriel Georgiev <[email protected]>
Co-authored-by: Gabriel Georgiev <[email protected]>
…/api/kerberos_client.py Co-authored-by: Gabriel Georgiev <[email protected]>
We are adding support for Kerberos authentication in the Control REST API . This is extending the support for the client to be able to make authentication requests with kerberos. This is part 1 adding KerberosClient "API" for the purpose of clients using it to get Kerberos authentication header. In a follow-up MR I will adopt it in vdk-control-cli Testing Done: automated tests Signed-off-by: Antoni Ivanov <[email protected]>
…/api/kerberos_client.py Co-authored-by: Momchil Z. <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Antoni Ivanov <[email protected]>
d5c545f
to
6f53109
Compare
mrMoZ1
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to merge after all tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding support for Kerberos authentication in the Control REST
API . This is extending the support for the client to be able to make
authentication requests with kerberos.
This is part 1 adding KerberosClient "API" for the purpose of clients
using it to get Kerberos authentication header.
In a follow-up MR I will adopt it in vdk-control-cli
Testing Done: automated tests
Signed-off-by: Antoni Ivanov [email protected]