versatile-data-kit: add logo image #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a Logo image on a dark backround Signed-off-by: Antoni Ivanov <[email protected]>
gabrielgeorgiev1
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Perhaps we could edit the readme to change the logo based on whether the user has dark or light mode enabled, example: https://dev.to/arnavkr/using-darklight-mode-specific-images-in-github-markdown-3iln
antoniivanov
added a commit
that referenced
this pull request
Jun 24, 2022
As suggested by Gabriel (#877 (review)): change the readme to change the logo based on whether the user has dark or light mode enabled, following: https://dev.to/arnavkr/using-darklight-mode-specific-images-in-github-markdown-3iln
Cool. Looks simple enough: #878 |
antoniivanov
added a commit
that referenced
this pull request
Jun 24, 2022
As suggested by Gabriel (#877 (review)): change the readme to change the logo based on whether the user has dark or light mode enabled, following: https://dev.to/arnavkr/using-darklight-mode-specific-images-in-github-markdown-3iln Testing Done: change theme and verified https://github.com/vmware/versatile-data-kit/tree/person/aivanov/images-readme looks appropriate Signed-off-by: Antoni Ivanov [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Logo image on a dark background.
Signed-off-by: Antoni Ivanov [email protected]