vdk-core: add option to disable version check #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version check is not needed always. Perhaps in cloud runs for example and we can skip it. We need option to do so. Signed-off-by: Antoni Ivanov <[email protected]>
gabrielgeorgiev1
approved these changes
Jun 24, 2022
|
Maybe update the description to mentioned how it was tested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version check is not needed always. Perhaps in cloud runs for example
and we can skip it. We need option to do so.
Testing Done: added unit tests
Signed-off-by: Antoni Ivanov [email protected]