vdk-control-cli: Fix command printed on successful deploy #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When successfully deploying a job, vdk-control-cli prints a command which can be used to check whether the deployment version was successfully updated. However, the printed command included the team name without brackets around it, which can be an issue as team names can have empty spaces in them, which meant the command gets parsed wrongly and fails. Signed-off-by: Gabriel Georgiev <[email protected]>
doks5
approved these changes
May 19, 2022
projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/deploy_cli_impl.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When successfully deploying a job, vdk-control-cli
prints a command which can be used to check whether
the deployment version was successfully updated.
However, the printed command included the team name
without quotes around it, which can be an issue as
team names can have empty spaces in them, which meant
the command gets parsed wrongly and fails.
Command used to look like:
Now it looks like:
Signed-off-by: Gabriel Georgiev [email protected]