[vdk-plugins] vdk-control-api-auth: Fix query key type #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing the query parameters from the redirect_url in the authorization code authentication flow, we converted the key of the parameter to bytes, which was causing TypeErrors due to missing encoding. This regression was not caught by the unit tests. This change fixes the regression by using plain strings as keys and removing any conversions to bytes. Additionally, unit test was fixed and extended to catch possible future regressions. Testing Done: Unit tests Signed-off-by: Andon Andonov <[email protected]>
gabrielgeorgiev1
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing the query parameters from the redirect_url in the
authorization code authentication flow, we converted the key of
the parameter to bytes, which was causing TypeErrors due to missing
encoding. This regression was not caught by the unit tests.
This change fixes the regression by using plain strings as keys
and removing any conversions to bytes.
Additionally, unit test was fixed and extended to catch possible
future regressions.
Testing Done: Unit tests
Signed-off-by: Andon Andonov [email protected]