control-service: Allow for jobs with no schedule to be deployed #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a job is deployed with no schedule_cron, the deployment will fail. After this change, jobs with no schedule will be deployed successfully, their cronjobs will have a default schedule "0 0 30 2 *" - meaning Feb 30, or never - but the job metadata will have an empty string for a schedule, so that "vdk list" will not print a schedule for those jobs (but jobs with their schedule explicitly set to "0 0 30 2 *" will still have it show). Testing done: TBD Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
mivanov1988
reviewed
May 16, 2022
...pelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java
Outdated
Show resolved
Hide resolved
|
LGTM! Please take a look at the failed tests. |
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
doks5
approved these changes
May 17, 2022
.../pipelines_control_service/src/test/java/com/vmware/taurus/service/JobImageDeployerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <[email protected]>
…are/versatile-data-kit into person/gageorgiev/tpcs-cron-schedule
mivanov1988
approved these changes
May 17, 2022
ivakoleva
approved these changes
May 17, 2022
.../pipelines_control_service/src/test/java/com/vmware/taurus/service/JobImageDeployerTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a job is deployed with no schedule_cron,
the deployment will fail. After this change, jobs with
no schedule will be deployed successfully, their cronjobs
will have a default schedule "0 0 30 2 *" - meaning Feb 30,
or never - but the job metadata will have an empty string
for a schedule, so that "vdk list" will not print a schedule
for those jobs (but jobs with their schedule explicitly set
to "0 0 30 2 *" will still have it show).
Testing done: tested locally by running control-service
connected to deployed K8s cluster, created and deployed
job successfully, verified that the created cronjob object
has its schedule set to "0 0 30 2 *", that executing the job
through the Execution API works and that getting the list of
deployed jobs returns an empty string for the schedule param
included 1 unit test covering the new addition
Signed-off-by: Gabriel Georgiev [email protected]